Bug 50447 - Text formatting changes (in docx-file) are not shown with track changes (and not recorded by the way)
Summary: Text formatting changes (in docx-file) are not shown with track changes (and ...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:7.3.0
Keywords: filter:docx
: 140640 (view as bug list)
Depends on:
Blocks: Track-Changes DOCX
  Show dependency treegraph
 
Reported: 2012-05-28 23:02 UTC by Timon
Modified: 2023-09-05 19:59 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
Example 7.docx - original file with comments, *.jpg - how document looks like in MS Office and LibreOffice (215.77 KB, application/x-zip-compressed)
2012-05-28 23:02 UTC, Timon
Details
pdf file exported with comments from MSOffice (167.83 KB, application/pdf)
2013-05-30 11:14 UTC, Timon
Details
Example 7 DOCX compared in MSO 2016 and LO 7.3+ (212.32 KB, image/jpeg)
2021-08-17 10:23 UTC, Timur
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Timon 2012-05-28 23:02:30 UTC
Created attachment 62191 [details]
Example 7.docx - original file with comments, *.jpg - how document looks like in MS Office and LibreOffice

LibreOffice 3.5.3.2 (Final) Russian UI/Locale
Build-ID: 235ab8a-3802056-4a8fed3-2d66ea8-e241b80
on Russian Windows XP Professional SP3 (32bit)

In LibreOffice 3.5.3 (Final) there is no comments (notes) with "formatting".

In MS Office 2007 SP3 all fine
Comment 1 Florian Reisinger 2012-09-29 15:53:26 UTC
Can't confirm this... The first line is not shown, because there is nothing to change. Where text is affected, everything is working compared to MS Office 2010
Comment 2 Timon 2012-09-29 18:18:28 UTC
Do not agree. MS Office shows not only comments, but also comments with formatting that was changed in document.
In the first line MS Office shows: "Formatted: no interval, to the left"
In the last line MS Office shows: "Formatted: Font: Bold"
LibO does not show such "formatting comments" at all.
Comment 3 Florian Reisinger 2012-09-29 19:54:04 UTC
The bold thing is shown in a different way (right click)...
Comment 4 QA Administrators 2013-05-29 23:04:49 UTC Comment hidden (obsolete)
Comment 5 Timon 2013-05-30 08:58:23 UTC
If you do think that there is no need to display comments with formatting changes, then I assume that bug is "resolved - invalid".
Comment 6 retired 2013-05-30 09:22:10 UTC
I tested the sample document with LO 4.1b1.

The comments all show in normal font. As screenshot of Timon shows MS Office displaying bold fonts in some comments.

I can use bold formatting in LO as well but it is not initially displayed for the sample document. REOPEN.
Comment 7 Timon 2013-05-30 10:45:42 UTC
(In reply to comment #6)
> I tested the sample document with LO 4.1b1.
> 
> The comments all show in normal font. As screenshot of Timon shows MS Office
> displaying bold fonts in some comments.
> 
> I can use bold formatting in LO as well but it is not initially displayed
> for the sample document. REOPEN.

The problem is slightly different. MSOffice indicates if document formatting was changed. For example, text was written in Arial 10, but another person made correction to Times New, 12, Bold. So we can see "Formatted: Font: Bold, Font Name: Times New, Font size: 12".

LibreOffice could not show such document changes.
Comment 8 Timon 2013-05-30 11:14:12 UTC
Created attachment 80030 [details]
pdf file exported with comments from MSOffice

As you can see, there are 2 more comments (first one and the last one) where formatting changes in commented text are shown. We can't see them in LibreOffice.
Comment 9 Joel Madero 2013-05-30 14:31:54 UTC Comment hidden (obsolete)
Comment 10 Jorendc 2013-12-29 00:17:11 UTC
Thanks to Adam, this comments are preserved (see bug 65265). Import of this comments is not implemented yet (bug 65262).

I hope you dont mind, but lets mark this bug as a dupe of bug 65262, because it's a little bit cleaner bug report.

Kind regards,
Joren

*** This bug has been marked as a duplicate of bug 65262 ***
Comment 11 Jorendc 2013-12-29 11:33:43 UTC
Sorry for the noise.

I think I was a bit to fast over here. Looks like bug 65262 is not a dupe of this one.

Kind regards,
Joren
Comment 12 QA Administrators 2015-04-19 03:22:56 UTC Comment hidden (obsolete)
Comment 13 Timon 2015-04-20 06:06:45 UTC Comment hidden (obsolete)
Comment 14 Telesto 2017-06-12 20:43:32 UTC
Still reproducible
Version: 5.5.0.0.alpha0+
Build ID: 076ed447f694239d5c67adee528ea6e471d909ff
CPU threads: 4; OS: Windows 6.19; UI render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2017-06-09_23:54:20
Locale: nl-NL (nl_NL); Calc: CL
Comment 15 Timur 2017-06-14 15:45:55 UTC Comment hidden (obsolete)
Comment 16 Timur 2017-06-14 15:53:56 UTC
This is not about bold and not even about docx. Even formatting changes in odt are not shown in details. 
So this bug may be: "Show text formatting changes with tracked changes". In order to be shown in margins, it requires Bug 34355 which is experimentally available, so it's not dependence now.
But Manage Track Changes has simple Action now: + and X although there exists Formats as a separate action, apart from Insertion and Deletion (and Table Changes).
Comment 17 Cor Nouws 2017-06-14 19:35:06 UTC
(In reply to Timur from comment #16)
> This is not about bold and not even about docx. Even formatting changes in
> odt are not shown in details. 

If I add comments to an odt, make part of that comment bold, close and reopen, the bold formatting of the comment is still there. So I don't understand what you want to say :)
Can you pleas explain?
Comment 18 Timur 2017-06-28 15:32:22 UTC
(In reply to Cor Nouws from comment #17)
> If I add comments to an odt, make part of that comment bold, close and
> reopen, the bold formatting of the comment is still there. So I don't
> understand what you want to say :)
> Can you pleas explain?
This bug is about text formatting changes that are not shown anywhere nor in comments and not about formatting of a comment.
Comment 19 László Németh 2021-08-16 11:52:34 UTC
tdf#50447 sw: track changes of character formatting

Only range of the formatting change was tracked,
but not the original direct character formatting of the text.
Now rejection of the tracked change of a text portion
resets the original direct formatting.

Note: nor ODT or DOCX export hasn't been supported, yet.

See also commit 5322663f8234836a6a4aaaed025c158fd7e8b67a
"tdf#126206 DOCX: add rejection of character formatting changes".
Comment 20 Commit Notification 2021-08-16 11:53:03 UTC
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0115a77eb84afb0d820d8e23f45e49b30b82a8d3

tdf#50447 sw: track changes of character formatting

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 21 NISZ LibreOffice Team 2021-08-17 07:42:05 UTC
*** Bug 140640 has been marked as a duplicate of this bug. ***
Comment 22 Timur 2021-08-17 10:23:58 UTC
Created attachment 174345 [details]
Example 7 DOCX compared in MSO 2016 and LO 7.3+

I confirm that Bug 140640 was resolved, as explained in Comment 19.
But it seems that the fix could have been for that bug. 

1. Please explain why the fix is for this bug. I don't see a change, with simple example of attachment 62191 [details]. Attached screenshot remained the same. 

2. MSO shows tracked formatting along with comments. 
LO records them in Manage Changes window (that can be in sidebar with Enable experimental features). It's not as in MSO but I think it's OK. But LO doesn't show what changes really are. 
In attachment 62191 [details] 1st change in MSO is "Formatted: No Spacing,Left, None". In LO, we can Accept or Reject but cannot see what change was. 

3. In attachment 62191 [details] last change is formatting (setting bold) by the same guy who inserted that text. MSO shows separately inserting from formatting, formatting can be rejected. 
LO shows a single change. Rejecting discards both text and formatting.