Bug 141742 - FILEOPEN PPTX: split animation import missing the anim:sub-item="text" attribute (regression)
Summary: FILEOPEN PPTX: split animation import missing the anim:sub-item="text" attrib...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.1.2.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL: https://dinosaurgames.io
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Object-Animations
  Show dependency treegraph
 
Reported: 2021-04-18 11:53 UTC by Pablo
Modified: 2023-11-28 10:06 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
PPTX with split animation (30.38 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2021-04-18 11:53 UTC, Pablo
Details
pptx converted to odp in LO 7.0 (12.31 KB, application/vnd.oasis.opendocument.presentation)
2021-04-18 11:54 UTC, Pablo
Details
pptx converted to odp in LO 7.1 (12.29 KB, application/vnd.oasis.opendocument.presentation)
2021-04-18 11:55 UTC, Pablo
Details
split animation created in LO 7.1 without import (10.94 KB, application/vnd.oasis.opendocument.presentation)
2021-04-18 11:56 UTC, Pablo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pablo 2021-04-18 11:53:01 UTC
Description:
The attached pptx has a split animation on a bullet list. The animation is imported correctly in LO 7.0 but in LO 7.1 the <anim:set> nodes are missing the anim:sub-item="text" attribute. This is a regression between 7.0.4.2 and 7.1.

Steps to Reproduce:
1. Import the attached pptx to LibreOffice 7.0 and LibreOffice 7.1 
2. Exported to ODP
3. Extract the ODP zip and compare the <anim:set> nodes in content.xml of both LibreOffice versions.

4. Create a new Impress 7.1 presentation.
5. Add a text box. Create a bullet list with 3 items (AAA, BBB, CCC).
6. Add split entrance animation to the text box.
7. Save as ODP.
8. Extract the ODP zip file and compare the <anim:set> nodes in content.xml to the ODP converted from the PPTX. Now the <anim:set> nodes do include the anim:sub-item="text" attribute.

Actual Results:
In Impress 7.1 <anim:set> nodes in content.xml are missing the anim:sub-item="text" attribute when importing a pptx with split animation.

<anim:par smil:dur="indefinite" smil:restart="never" presentation:node-type="timing-root">
    <anim:seq smil:dur="indefinite" presentation:node-type="main-sequence">
        <anim:par smil:begin="next" smil:fill="hold">
            <anim:par smil:begin="0s" smil:fill="hold">
                <anim:par smil:begin="0s" smil:fill="hold" presentation:node-type="on-click" presentation:preset-class="entrance" presentation:preset-id="ooo-entrance-split" presentation:preset-sub-type="horizontal-in">
                    <anim:set smil:begin="0s" smil:dur="0.001s" smil:fill="hold" smil:targetElement="id1" smil:attributeName="visibility" smil:to="visible"/>
                    <anim:transitionFilter smil:dur="0.5s" smil:targetElement="id1" smil:type="barnDoorWipe" smil:subtype="horizontal" smil:direction="reverse"/>
                </anim:par>
            </anim:par>
        </anim:par>
    </anim:seq>
</anim:par>

Expected Results:
In Impress 7.0 <anim:set> nodes in content.xml include the anim:sub-item="text" attribute when importing a pptx with split animation.
In Impress 7.1 the attribute is included only when creating a new text box (not importing pptx).

<anim:par smil:dur="indefinite" smil:restart="never" presentation:node-type="timing-root">
    <anim:seq presentation:node-type="main-sequence">
        <anim:par smil:begin="next">
            <anim:par smil:begin="0s">
                <anim:par smil:begin="0s" smil:fill="hold" presentation:node-type="on-click" presentation:preset-class="entrance" presentation:preset-id="ooo-entrance-split" presentation:preset-sub-type="horizontal-in">
                    <anim:set smil:begin="0s" smil:dur="0.004s" smil:fill="hold" smil:targetElement="id1" anim:sub-item="text" smil:attributeName="visibility" smil:to="visible"/>
                    <anim:transitionFilter smil:dur="2s" smil:targetElement="id1" anim:sub-item="text" smil:type="barnDoorWipe" smil:subtype="horizontal" smil:direction="reverse"/>
                </anim:par>
            </anim:par>
        </anim:par>
    </anim:seq>
</anim:par>


Reproducible: Always


User Profile Reset: No



Additional Info:
Bad version:
Version: 7.1.2.2 / LibreOffice Community
Build ID: 5751006d328844ba3fa6124ed263bbf122f0788a
CPU threads: 2; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: en-US (en_IL); UI: en-US
Calc: threaded

Good version:
Version: 7.0.4.2
Build ID: 00(Build:2)
CPU threads: 2; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: en-US (en_IL); UI: en-US
Ubuntu package version: 1:7.0.4_rc2-0ubuntu0.20.04.2
Calc: threaded
Comment 1 Pablo 2021-04-18 11:53:37 UTC
Created attachment 171268 [details]
PPTX with split animation
Comment 2 Pablo 2021-04-18 11:54:30 UTC
Created attachment 171269 [details]
pptx converted to odp in LO 7.0
Comment 3 Pablo 2021-04-18 11:55:10 UTC
Created attachment 171270 [details]
pptx converted to odp in LO 7.1
Comment 4 Pablo 2021-04-18 11:56:00 UTC
Created attachment 171271 [details]
split animation created in LO 7.1 without import
Comment 5 Xisco Faulí 2021-04-22 09:51:33 UTC
The visual result is the same exporting the PPTX to ODP in 7.1 and 7.0.
What is the impact of the missing <anim:set> for you ?
Comment 6 Pablo 2021-04-22 10:26:59 UTC
The visual result when presenting and playing the animations is the same but the xml structure of the animations is different and probably wrong. I have PyUno code that relies on the anim:sub-item="text" attribute that now doesn't work.

Why does the spec has the anim:sub-item="text" attribute if it's useless?
Why is there a difference between the xml of the same animation imported from pptx and created directly in LO?

If you compare the animation pane in Impress of the odp created from the pptx import and the odp created from a a blank impress presentation you'll see the different structure of the animations.
Comment 7 QA Administrators 2021-04-23 04:02:08 UTC Comment hidden (obsolete)
Comment 8 Timur 2021-06-10 12:21:27 UTC
Linux 7.0:
commit ac66702731994e40108d28de947a328625c64109
Date:   Thu Jan 21 18:56:37 2021 +0100
    source d56e4aea5fd5d777204f9f4e4b14cf0047348beb
    previous 6d49ac8214b7d084d07469a6ce2414788f8ef9e0

author	Mark Hung <marklh9@gmail.com>	2021-01-16 23:48:56 +0800
committer	Xisco Fauli <xiscofauli@libreoffice.org>	2021-01-21 15:30:11 +0100
commit d56e4aea5fd5d777204f9f4e4b14cf0047348beb (patch)
tdf#128550 set sub item on the ancestor node.
Comment 9 Timur 2021-06-11 07:14:08 UTC
Hi Mark. Can you please comment on this, it's from your commit?
I hope Regina will also explain.
Comment 10 QA Administrators 2023-06-12 03:11:26 UTC
Dear Pablo,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug