Bug 141398 - Single reference search result should be highlighted (see comment 5 item 2)
Summary: Single reference search result should be highlighted (see comment 5 item 2)
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.4.2.2 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisectRequest
Depends on:
Blocks: Cross-reference-dialog
  Show dependency treegraph
 
Reported: 2021-03-31 16:32 UTC by Christian Lehmann
Modified: 2024-04-07 14:45 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
odt file to demonstrate the bug (132.71 KB, application/vnd.oasis.opendocument.text)
2021-04-16 06:34 UTC, Christian Lehmann
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Lehmann 2021-03-31 16:32:47 UTC
Description:
Insert cross-reference:
The dialog box has a section 'Selection'. In the 'Filter Selection' field, the user can write the number of the object he wants to cross-reference.
- The filtered list below offers not only the numbered objects themselves, but also references to them. The latter are not wanted; the user wants to refer to a numbered object, not to a reference.
- Once the list of numbered objects has shrunk down to a single object, this is what the user wants to cross-reference. The cursor should then automatically move down to select this object, so that it will suffice for the user to hit Return.
(Both of these features used to be okay in Writer up to and including LO 5.)


Steps to Reproduce:
1. Hit ALT-i.
2. Choose 'Cross-reference'.
3. Click in 'Filter Selection'.
4. Type initial characters of reference sought.

Actual Results:
1) In the area below the Selection field, the numbered object is listed, but also references to it.
2) The graphic cursor remains in the Selection field even if the single fitting object is identified.

Expected Results:
1) Only the numbered object itself should be listed (as it used to be case in earlier versions of LO).
2) If only one object is listed, the cursor should highlight it.


Reproducible: Always


User Profile Reset: No



Additional Info:
These are really enhancements rather than bugs. However, the enhancements suggested are not new; they are properties that were present in earlier versions. Their destruction amounts to a bug.
Comment 1 Dieter 2021-04-15 06:32:28 UTC
Thank you for reporting the bug. Please attach a sample document, as this makes it easier for us to verify the bug. 
I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the requested document is provided.
(Please note that the attachment will be public, remove any sensitive information before attaching it)
Comment 2 Christian Lehmann 2021-04-16 06:34:01 UTC
Created attachment 171231 [details]
odt file to demonstrate the bug

The sample document 'test.odt' contains many occurrences of "Error: Reference source not found" because it is an excerpt of a much larger file. This is immaterial to the problem at hand.

First try:
At any position in the document, I want to insert a reference to section 2.1.3.
Hit: Insert > Cross-reference
Type: Numbered Paragraphs
Insert reference to: Number (no context)
Selection:  2.1.3

Result:
The list below the selection field contains 11 (pseudo-)hits. Only the first one is correct.  The next two lines are paragraphs that contain a reference to section 2.1.3. Should not be listed.
The following lines show headings whose number includes the sequence 2.1.3. Should not be listed.


Second try:
At any position in the document, I want to insert a reference to section 1.1.2.
Hit: Insert > Cross-reference
Type: Numbered Paragraphs
Insert reference to: Number (no context)
Selection:  1.1.2

Result: A single target is shown. Correct.
However, the cursor should be in the list field, marking the target found, so that it suffices for me to hit 'Insert'.
Comment 3 QA Administrators 2021-04-17 04:08:33 UTC Comment hidden (obsolete)
Comment 4 Dieter 2021-04-18 16:00:51 UTC
(In reply to Christian Lehmann from comment #2)
> Type: Numbered Paragraphs
Please choose "Headings" instead

Numbered paragraphs is every paragraph with a (numbered) list

> However, the cursor should be in the list field, marking the target found,
> so that it suffices for me to hit 'Insert'.
LO displays result from the moment you start typing. So for me it's expected, that Searching filed is still active.

Does this solve your problem?
=> NEEDINFO
Comment 5 Christian Lehmann 2021-04-18 16:56:48 UTC
On the one hand, I find it pleasant to receive advice how I can circumvent problems that I encounter. On the other hand, they sometimes tend to downplay the existence of a real bug.

1) I could, of course, choose 'Headings' as Type whenever I want to refer to a section. However, equally often I want to refer to a numbered paragraph which is not a heading. I would then have to select the Type at every given instance, which amounts to as much work as the target selection which I complained about in the first place.
Even in the Headings list, headings are shown which I am not looking for. E.g., always using the sample file I provided and having selected Type 'Headings', type "2.1.1" in the Selection field. Beside the heading looked for, you will see another one (2.2.2.1.1) which you did not look for (if you were searching it, you would type "2.2.2." etc.)
Needless to say, the problem I reported is the same if you reference some object which is not a heading. E.g., start typing "e28" in the Selection, and you will see a paragraph in the list that does not belong there.

2) As to your comment
"LO displays result from the moment you start typing. So for me it's expected, that Searching filed is still active."
we may have a misunderstanding. Select Type "Headings" and, in the Selection field, type "2.1.2.1". This identifies a single target. In the list field, this should automatically be highlighted (as it used to be the case in earlier LO versions). Instead, the cursor remains in the Selection field.
Comment 6 QA Administrators 2021-04-19 03:40:17 UTC Comment hidden (obsolete)
Comment 7 Mike Kaganski 2021-04-19 16:09:14 UTC
If I understand correctly, Christian Lehmann wants the "Selection" input field, where user types something to filter the results, to only take numbers into account, not the text of the numbered paragraph? It would be absolutely wrong for most of the users, who may want to type the text and find the corresponding item, and only makes sense for users who somehow know all their numbers in a heavily numbered document (well, I hardly imagine many people who know by heart all the numbers in a document with hundreds of numbered paragraphs, while I easily know people who may reasonably remember some part of text in the item they need).
Comment 8 Mike Kaganski 2021-04-19 16:36:17 UTC
(In reply to Christian Lehmann from comment #5)
> Select Type "Headings" and, in the Selection
> field, type "2.1.2.1". This identifies a single target. In the list field,
> this should automatically be highlighted (as it used to be the case in
> earlier LO versions). Instead, the cursor remains in the Selection field.

I confirm that in Version: 6.2.0.3 (x64)
Build ID: 98c6a8a1c6c7b144ce3cc729e34964b47ce25d62
CPU threads: 12; OS: Windows 10.0; UI render: GL; VCL: win; 
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: CL

typing '2' in the Selection makes the top element on the filtered list to be selected,

while starting from Version: 6.3.0.4 (x64)
Build ID: 057fc023c990d676a43019934386b85b21a9ee99
CPU threads: 12; OS: Windows 10.0; UI render: GL; VCL: win; 
Locale: ru-RU (ru_RU); UI-Language: en-US
Calc: CL

typing '2' makes the resulting list to *not* have any selection.

I don't know if this was intentional, or some accidental breakage from, say, welding work. Marking bibisectrequest *for this aspect only*.
Comment 9 Christian Lehmann 2021-04-19 16:57:23 UTC
(In reply to Mike Kaganski from comment #7)
> If I understand correctly, Christian Lehmann wants the "Selection" input
> field, where user types something to filter the results, to only take
> numbers into account, not the text of the numbered paragraph? It would be
> absolutely wrong for most of the users, who may want to type the text and
> find the corresponding item, and only makes sense for users who somehow know
> all their numbers in a heavily numbered document (well, I hardly imagine
> many people who know by heart all the numbers in a document with hundreds of
> numbered paragraphs, while I easily know people who may reasonably remember
> some part of text in the item they need).

This is a misunderstanding.
1) If I want to refer to the object numbered 'X', then I type 'X' in the selection field and I only want to see that exact paragraph which is numbered 'X', and not dozens of paragraphs which happen to contain the expression 'X'.

2) The question of how I know that it is X that I want to refer to is a different one. If it is a heading, then my method is to look at the Navigator. Searching for a word or string that is part of the heading would be inefficient since that string may occur dozens of times in numbered paragraphs of all sorts.

However, if you want to offer the user alternative ways of finding the paragraph he wants to refer to, then we are not talking about Types of reference targets (that is what the dialog field is called), but about search strategies. You may then wish to offer:
a) Search by number [where 'number' means 'paragraph/heading/footnote etc. number]
b) Search by content.
Comment 10 Mike Kaganski 2021-04-19 17:04:37 UTC
(In reply to Christian Lehmann from comment #9)
> This is a misunderstanding.
> 1) If I want to refer to the object numbered 'X', then I type 'X' in the
> selection field and I only want to see that exact paragraph which is
> numbered 'X', and not dozens of paragraphs which happen to contain the
> expression 'X'.

Heh, no. This was not a misunderstanding on *my* part, but you substitute a discussion of "what is best for most" with your personal preference. Quite valid as an enhancement request, no problem in that.

> However, if you want to offer the user alternative ways of finding the
> paragraph he wants to refer to, then we are not talking about Types of
> reference targets (that is what the dialog field is called), but about
> search strategies. You may then wish to offer:
> a) Search by number [where 'number' means 'paragraph/heading/footnote etc.
> number]
> b) Search by content.

So your proposal seems to be "allow me to search by number only, in addition to the already existing method of searching by matching in any place of paragraph text". I agree that would be a valid enhancement (though not trivial, since Writer's link provider only gives strings, not structure internally - but that's an implementation detail that user does not have to think about), unless a simple "match from the start of the paragraph text" would suffice.
Comment 11 Christian Lehmann 2021-04-20 08:46:11 UTC
The reference to a numbered target has the same number as its target, otherwise the reader would hardly be able to follow it up. Since the target is identified by the reference, it is a natural user strategy to use its number in the selection field in order to pin it down. This is not a "personal preference" of mine, but has been standard in earlier versions of LO.

It is true that in my former post, the word 'I' was used to refer to the user. I will not repeat this mistake. It is not a fruitful communication strategy to personalize an exchange whose object is the functionality of LO. As long as there is sufficient evidence that a certain behavior of LO would be useful for a set of users, the question of whether the reporter or the developer have a personal preference for it is of little importance.

Now as to the technical aspect: It is true that in the Numbering Styles, Writer allows for Numbering alignment not only at the left, but also at the right side and even centered. So as long as the link provider does not identify the "number" of a numbered element (where, in LO jargon, a "number" is anything used to label a paragraph), it is true that the enhancement proposed would initially only work for numbers in initial position, as you say. (Users numbering mathematical or logical formulas at the page margin would be disadvantaged by that.)
Comment 12 Mike Kaganski 2021-04-20 09:03:24 UTC
(In reply to Christian Lehmann from comment #11)
> This is not a "personal preference" of mine, but has been standard in
> earlier versions of LO.

No, I have checked in all 10 major versions starting from v. 5.2 (where the selection box was introduced [1]). and it was always the same: it searched the entered text anywhere in the text of paragraph. E.g., entering "3.2" would bring 13 results, including "2. final infinitival: ch. 2.1.3.2." and "2.2.2.1.3.2. Frustrated action construction".

Furthermore, as I mentioned above, it is incorrect to imply that the preference to use numbers in the search is universal; in writing, the numbering is automatic, and user often does not even know which number one of the point might have at any given time, because of added or removed or restructured points above.

> As long as there is sufficient evidence that a certain behavior of LO would
> be useful for a set of users, the question of whether the reporter or the
> developer have a personal preference for it is of little importance.

Your proposal was re-worded at the end of comment 10 to follow that idea :-)

> Now as to the technical aspect: It is true that in the Numbering Styles,
> Writer allows for Numbering alignment not only at the left, but also at the
> right side and even centered. So as long as the link provider does not
> identify the "number" of a numbered element (where, in LO jargon, a "number"
> is anything used to label a paragraph), it is true that the enhancement
> proposed would initially only work for numbers in initial position, as you
> say. (Users numbering mathematical or logical formulas at the page margin
> would be disadvantaged by that.)

Yes.

[1] https://wiki.documentfoundation.org/ReleaseNotes/5.2#Selection_Filter_in_Cross_Reference_Tab
Comment 13 Christian Lehmann 2021-04-20 09:42:51 UTC
(In reply to Mike Kaganski from comment #12)
> (In reply to Christian Lehmann from comment #11)
> > This is not a "personal preference" of mine, but has been standard in
> > earlier versions of LO.
> 
> No, I have checked in all 10 major versions starting from v. 5.2 (where the
> selection box was introduced [1]). and it was always the same: 

Okay, then that was out of unreliable memory. Then please just take into account the user who uses the Navigator to identify the targets for references to sections.
Comment 14 Mike Kaganski 2021-04-20 09:54:31 UTC
(In reply to Christian Lehmann from comment #13)
> (In reply to Mike Kaganski from comment #12)
> > (In reply to Christian Lehmann from comment #11)
> > > This is not a "personal preference" of mine, but has been standard in
> > > earlier versions of LO.
> > 
> > No, I have checked in all 10 major versions starting from v. 5.2 (where the
> > selection box was introduced [1]). and it was always the same: 
> 
> Okay, then that was out of unreliable memory. Then please just take into
> account the user who uses the Navigator to identify the targets for
> references to sections.

Then please decide what to do with this bug, taking into account that this bug must continue with only one of the two different issues:

1. A regression (or was it deliberate decision?) that selection in the list disappears as soon as initially selected item gets filtered out (this is why I marked this bibisectrequest in comment 8);
2. An enhancement request to allow limiting filtering to numbers only.

Please keep this bug only for one of the two (and update title, pointing to a comment that provides an updated summary), and please file the other separately.
Comment 15 Christian Lehmann 2021-04-20 10:28:14 UTC
So summarizing the regression:
In the dialog for insertion of a cross-reference, the user has typed in the Selection field enough text to reduce the list of possible targets to one. In this moment, the target for the reference should be highlighted so that it suffices for the user to press the OK button.
Comment 16 Christian Lehmann 2021-04-20 10:56:13 UTC
The enhancement proposed is now deferred to Bug 141777.
Comment 17 Dieter 2021-04-22 15:06:04 UTC
(In reply to Christian Lehmann from comment #15)
> So summarizing the regression:
> In the dialog for insertion of a cross-reference, the user has typed in the
> Selection field enough text to reduce the list of possible targets to one.
> In this moment, the target for the reference should be highlighted so that
> it suffices for the user to press the OK button.

Mike confirmed this bug in comment 8
=> NEW
Comment 18 Christian Lehmann 2022-04-07 08:26:39 UTC
Closely related to this bug:
Produce the following situation: In the Selection field of the Cross-reference dialog, you have entered enough text to produce a list of possible targets in the field below it.
Now press TAB to jump to the first entry of this field. This should now be highlighted. It is not, so you are misled to the impression that TAB did nothing.
Comment 19 QA Administrators 2024-04-07 03:14:27 UTC Comment hidden (obsolete)
Comment 20 Christian Lehmann 2024-04-07 14:45:03 UTC
Comment 18 is a real bug. It persists in the most recent versions of LO.
Comment 15 is an enhancement. It has not been taken care of, either.
They are treated here in one bug report because they obviously concern the same user action and could be remedied on one go.