Bug 136445 - RTF import: comment/annotation anchor is in wrong cell (covered cell even) in table
Summary: RTF import: comment/annotation anchor is in wrong cell (covered cell even) in...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Michael Stahl (allotropia)
URL:
Whiteboard: target:7.1.0 target:7.0.3 target:24.8...
Keywords: bibisected, bisected
Depends on:
Blocks: Writer-Comments
  Show dependency treegraph
 
Reported: 2020-09-03 17:22 UTC by Telesto
Modified: 2024-02-09 13:55 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (2.34 MB, application/msword)
2020-09-03 17:22 UTC, Telesto
Details
bit smaller bugdoc, just the problematic comment (57.44 KB, application/rtf)
2020-09-18 16:58 UTC, Michael Stahl (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-09-03 17:22:39 UTC
Description:
Write-protected content cannot be changed error box appears when deleting comments in RTF (comments will be deleted)

Steps to Reproduce:
1. Open the attached file
2. Page 2 -> Delete all comments of Christian

Actual Results:
Write-protected content cannot be changed error

Expected Results:
No error dialog


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 1e0cfd5662d95cea84e80e4fe10d52c3b1101ae6
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2020-09-03 17:22:58 UTC
Created attachment 165111 [details]
Example file
Comment 2 Telesto 2020-09-03 17:23:35 UTC
Not in
Versie: 4.4.7.2 
Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
Locale: nl_NL
Comment 3 Attila Baraksó (NISZ) 2020-09-16 07:43:42 UTC
Reproduced in:

Version: 7.1.0.0.alpha0+ (x64)
Build ID: 8c18cd6823ddf4ef5ba67801a84cee26c9b5a9a6
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: threaded
Comment 4 Attila Baraksó (NISZ) 2020-09-16 08:32:40 UTC
Bibisected using bibisect-win64-7.0 to:
URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=0788ab19869aa2ae5f7fbef9e3c13ceb641f80ee
author: Michael Stahl <michael.stahl@cib.de>
committer: Michael Stahl <michael.stahl@cib.de>
summary: sw: read-only/protected content dialog was missing on Delete/Backspace

Adding CC: Michael Stahl
Comment 5 Michael Stahl (allotropia) 2020-09-18 15:33:31 UTC
something very weird is going on in a table where this comment is anchored:
"Si las formas de voz media estativa son infinitas o al menos semi-finitas, convendría separarlas de esta tabla."

it's not supposed to be where it is, apparently in a covered table cell, but that's not really possible.
Comment 6 Michael Stahl (allotropia) 2020-09-18 16:58:25 UTC
Created attachment 165667 [details]
bit smaller bugdoc, just the problematic comment
Comment 7 Michael Stahl (allotropia) 2020-09-21 08:57:45 UTC
turned out this isn't a recent regression...


Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/54bd2266d6e0c8926ecaf0fbb2dbb5ee9d1a802d

tdf#136855 writerfilter: RTF import: buffer annotations inside tables

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2020-09-21 17:11:02 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/fbc78668d4a95934fb0470ef2172aceedb806172

tdf#136445 writerfilter: RTF import: buffer annotations inside tables

It will be available in 7.0.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 BogdanB 2020-09-23 15:24:23 UTC
No error dialog. I can delete all comments.

Verified with
Version: 7.1.0.0.alpha0+
Build ID: 121771e37f7e2de41cd5643475861062bf25627b
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 10 Commit Notification 2024-02-02 16:17:36 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/86ad08f9d25110e91e92a0badf6de75e785b3644

writerfilter: fix missing paragraph break on tdf136445-1.rtf

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2024-02-06 19:35:06 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/b5a31c9cd0b53957a716a487e203f13919bac64c

writerfilter: fix missing paragraph break on tdf136445-1.rtf

It will be available in 24.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2024-02-09 13:55:13 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/31b91266357b2215372596181108aa6cd2513182

writerfilter: fix missing paragraph break on tdf136445-1.rtf

It will be available in 7.6.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.