With the arrival Colibre as the default icon theme for Windows system with whatever reason online help now using Colibre as the icon theme for of the choice and hardcorded (CMIIW) in the build system. As we know LibreOffice should be blend to the operating system then had using different icon theme (Breeze for KDE Plasma 5 & macOS (hopefully macOS switch to Sukapura tdf#130500), Colibre for Windows and elementary for GNOME family). Furthermore, user has the high flexibility to use whatever s/he wants. With this kind of situation, it's a bit of strange if the icon theme that being used by user in his local system than different with icon theme in the online help/documentation. So my suggestion is to add possibility to change icon theme in the online help based on user local choice. May be we can utilize local user directory configuration as a base parameter that could transform URL or something like that.
Do you expect the help system to produce images on the fly from user's installed custom icon theme? Or to add a workload on help authors to prepare those duplicating image sets? And increase help package size considerably? WF IMO.
(In reply to Mike Kaganski from comment #1) > Do you expect the help system to produce images on the fly from user's > installed custom icon theme? I just think about only icon theme that available in the core, so >>> Or to add a workload on help authors to prepare > those duplicating image sets? And increase help package size considerably? > > WF IMO. >>> just duplicating current theme. What do you mean with help package size? I'm talking about online help.
(In reply to Rizal Muttaqin from comment #2) > just duplicating current theme. What do you mean with help package size? > I'm talking about online help. Online help and offline help are the same.
(In reply to Mike Kaganski from comment #3) > (In reply to Rizal Muttaqin from comment #2) > > just duplicating current theme. What do you mean with help package size? > > I'm talking about online help. > > Online help and offline help are the same. OK then for the sake of installation size, I suggest to use the icon theme files that already installed.
(In reply to Rizal Muttaqin from comment #4) > OK then for the sake of installation size, I suggest to use the icon theme > files that already installed. Guess what: they are all installed - at least in 95% of cases (i.e., on Windows using MSI, which doesn't even have a selector for icon themes to install)! And further: detecting which is selected is also incorrect, since the user that installs the MSI is not necessarily the one that will be using the help (and even when they are the same user, it would fail when the user is installing LO for the first time, and installs the help at the same time, not having done the first start and configuration yet). My take is still WF.
(In reply to Mike Kaganski from comment #5) And users not only care about installation size, but also about installer size - see e.g. tdf#97991 (which I personally dislike, but still think it's not wise to increase installer size unnecessarily, especially in view of tdf#124992).
(In reply to Rizal Muttaqin from comment #0) > icon theme (Breeze for... macOS Sukapura, Colibre for Windows... I don't like this n to n view. Ideally we have only one icon theme and allow users to add more, IMHO, but we try to match with the OS. Nevertheless you can add own themes per extension and at least at this point the help would not be congruent anymore. => WF (while I admit that looking at Colibre as a Breeze user could be weird). Olivier, what do you think?
(In reply to Heiko Tietze from comment #7) > (In reply to Rizal Muttaqin from comment #0) > > icon theme (Breeze for... macOS Sukapura, Colibre for Windows... > > I don't like this n to n view. Ideally we have only one icon theme and allow > users to add more, IMHO, but we try to match with the OS. Nevertheless you > can add own themes per extension and at least at this point the help would > not be congruent anymore. => WF (while I admit that looking at Colibre as a > Breeze user could be weird). > > Olivier, what do you think? ping
(In reply to Heiko Tietze from comment #7) > (In reply to Rizal Muttaqin from comment #0) > > icon theme (Breeze for... macOS Sukapura, Colibre for Windows... > > I don't like this n to n view. Ideally we have only one icon theme and allow > users to add more, IMHO, but we try to match with the OS. Nevertheless you > can add own themes per extension and at least at this point the help would > not be congruent anymore. => WF (while I admit that looking at Colibre as a > Breeze user could be weird). > > Olivier, what do you think? Colibre is actually hard-coded in the build of the Help. Passing another param to indicate the icons set requires C++ development (< 5 lines). All target icon set must be available in the Help (local and online) in thee /media/ folder, if not, the defaulted to an existing icon set. Icon to use in Help (src="...") can be selected by a javascript stub that read icon set name, map replacement table and display.