Bug 123665 - Inconsistent behavior of "find next" in slides and notes
Summary: Inconsistent behavior of "find next" in slides and notes
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
6.1.5.2 release
Hardware: x86 (IA32) All
: low minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Find-Search Notes-View
  Show dependency treegraph
 
Reported: 2019-02-23 15:20 UTC by David F Smith
Modified: 2023-04-21 13:25 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Example presentation, as described. (11.47 KB, application/vnd.oasis.opendocument.presentation)
2019-02-23 15:22 UTC, David F Smith
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David F Smith 2019-02-23 15:20:44 UTC
Description:
When searching for text in slides, Enter (meaning "find next") stops working after switching to slide notes.  The "find next" button switches to slide notes without finding the text, but then starts working again.

Steps to Reproduce:
I first created a test presentation with the following three slides:
Slide Title   Slide Notes
  Slide 1     First page of notes
              This is the first slide of three
  Slide 2     Second page of notes
              This is the second slide of three
  Slide 3     Third page of notes
              This is the third slide of three

1. In the slide pane, click on the first slide.  If necessary, click on the Normal tab to display the slide.

2. Choose Edit / Find, or press Ctrl-F.  In the search box, type "slide" (without the quotes) and press Enter.  On Slide 1, the word "Slide" is highlighted.

3. Press Enter twice more.  Each time, the word "Slide" is highlighted on a slide.

4. Press Enter again.  The display switches to Notes view of Slide 1, but nothing is highlighted, even though "slide" appears in the note.

5. Continue pressing Enter.  Nothing happens.

6. Click "find next" (the large down-arrow in the Find toolbar at the bottom of the screen).  "Slide" is highlighted in the Notes for Slide 1.  Press "find next" twice more.  "Slide" is highlighted in the notes of the next two slides.

----------------

Slightly different behavior, using "find next."

1. In the slide pane, click on the first slide.  Click on the Normal tab to display the slide.

2. Choose Edit / Find, or press Ctrl-F.  In the search box, type "slide" (without the quotes) and click the "find next" button (the large down-arrow in the Find toolbar).  On Slide 1, the word "Slide" is highlighted.

3. Click the "find next" button twice more.  Each time, the word "Slide" is highlighted on a slide.

4. Click "find next" again.  The display switches to Notes view of Slide 1, but nothing is highlighted, even though "slide" appears in the note.

5. Click "find next" again.  "Slide" is highlighted in the Notes for Slide 1.  Press "find next" twice more.  "Slide" is highlighted in the notes of the next two slides.


Actual Results:
See above.  The Enter key, as "find next," stops working after switching from Notes view to Normal View.  The "find next" button fails to work on the click that switches to Notes view but then resumes working.

Expected Results:
Consistent behavior of both Enter and "find next" when searching for text in slides and notes.


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
Version: 6.1.5.2 (x64)
Build ID: 90f8dcf33c87b3705e78202e3df5142b201bd805
CPU threads: 4; OS: Windows 10.0; UI render: default; 
Locale: en-US (en_US); Calc: group threaded
Comment 1 David F Smith 2019-02-23 15:22:20 UTC
Created attachment 149546 [details]
Example presentation, as described.
Comment 2 David F Smith 2019-02-23 15:23:27 UTC
This might be related to bug 123658.
Comment 3 Durgapriyanka 2019-02-27 18:35:15 UTC
Thank you for reporting the bug. Unfortunately I cannot reproduce the bug. When switching occurs, it works fine and does highlight the word "slide".

Version: 6.3.0.0.alpha0+
Build ID: b6b28931435e44aca92b8c0e1659f701e3ed1a87
CPU threads: 2; OS: Windows 6.1; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-01-30_06:57:04
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded
Comment 4 mulla.tasanim 2019-03-16 23:54:01 UTC
Hello David

Thank you for reporting the bug.
Both Enter and "find next" are working fine when searching for text in slides and notes.
I can not reproduce the bug in

Version: 6.2.1.2 (x64)
Build ID: 7bcb35dc3024a62dea0caee87020152d1ee96e71
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: CL


Version: 6.3.0.0.alpha0+ (x64)
Build ID: 91cdf22b88a4f7bec243c8fb187627e766d3294c
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-03-08_00:38:10
Locale: en-US (en_US); UI-Language: en-US
Calc: CL
Comment 5 Buovjaga 2019-03-17 10:57:15 UTC
David: I would ask you to try with 6.2, but possibly you do not want to upgrade yet. Instead, you can give our master build a spin: https://dev-builds.libreoffice.org/daily/master/Win-x86_64@42/current/

It installs separately, so will not affect your stable installation in any way.

Set to NEEDINFO.
Change back to UNCONFIRMED, if the problem persists. Change to RESOLVED WORKSFORME, if the problem went away.
Comment 6 David F Smith 2019-04-15 15:41:02 UTC
I retested under 6.2.2.2, and I now see slightly similar, but slightly different, behavior from my original report.

Immediately after starting LibreOffice, I opened my test presentation and performed my test steps 1-5.  At step 4, the word "slide" was highlighted in the note (as expected), but when I pressed Enter again to find the next occurrence, the word "slide" was replaced by a newline, showing that it had been selected for edit.

I undid that change (with Ctrl-Z) and repeated steps 1-5.  This time the behavior at step 4 was as I originally reported: "slide" was not highlighted in the note, and additional presses of Enter did nothing.

I closed the presentation and reopened it, and the same thing happened: first time, "slide" was found on the first note but selected for editing/replacement; second time, "slide" was not found on the note.

I closed the presentation, exited LibreOffice, restarted LibreOffice, opened the presentation, and now the behavior is as I originally reported: "slide" is not found on the first note, using the Enter key as "Find next."

I also noticed that if at step 4, when nothing is highlighted in the note, I click the "find next" arrow, "slide" is highlighted in the note, but there is also a blinking edit cursor after the word, so that if I press Enter, the word is replaced.

My original report listed additional steps that use the "find next" arrow.  The behavior that I see now is identical to what I reported originally: when "find next" moves to the first note, "slide" is not highlighted.  A second click highlights "slide" in the first note, but now I see that there is a blinking cursor after the word, so that again, if I press Enter, the word is replaced.

Apologies for the lengthy comment.  In summary, the behavior that I see under 6.2.2.2 is very similar to what I originally reported and is not what I consider to be correct.  "Find next," whether with the Enter key or the arrow, acts inconsistently when switching from slides to notes.


Version: 6.2.2.2 (x64)
Build ID: 2b840030fec2aae0fd2658d8d4f9548af4e3518d
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded
Comment 7 Buovjaga 2019-04-20 14:00:55 UTC
Ok, let's update steps:
1. Open attachment 149546 [details]
2. Focus on quick find bar, input slide
3. Press Enter five times

The fifth press replaces the "Slide" text of "Slide 1".

The behaviour was worse in older versions. The second pressing of Enter in 3.3.0 already replaces the selected text.

Arch Linux 64-bit
Version: 6.3.0.0.alpha0+
Build ID: b8f33d053c2cbf05872cf9ddfeff4cc302ee281f
CPU threads: 8; OS: Linux 5.0; UI render: default; VCL: gtk3; 
Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US
Calc: threaded
Built on 20 April 2019
Comment 8 QA Administrators 2021-04-20 03:54:22 UTC Comment hidden (obsolete)
Comment 9 David F Smith 2021-04-20 13:57:05 UTC
As requested, I retested under v7.0.5.2, and in summary, the behavior (which is inconsistent between slides and notes and between Enter Key and Find Next button) is as I reported.

In the first tests, using the Enter key to mean "Find Next" in the Find bar, the behavior was exactly the same as in my original report: the first three presses of Enter display the three slides, with "Slide" highlighted, while the fourth displays the Notes from slide 1 with nothing highlighted.  Additional presses do nothing.  (This is different from the behavior in my Comment 6, and I cannot explain the difference.)

In the second set of tests, using the down-arrow in the Find bar to mean "Find Next," the behavior was also exactly the same as in my original report: clicks 1-3 display the three slides, with "Slide" highlighted; click 4 displays the Notes from slide 1 with nothing highlighted; clicks 5-7 display the Notes from the three slides, with "slide" highlighted; click 8 displays slide 1 with nothing highlighted; and clicks 9-11 display the three slides, with "Slide" highlighted.  And so on.

In summary, the behavior that I see is as I originally reported.  I can't explain what I saw in comment 6, nor can I explain why others saw nothing wrong.

Version: 7.0.5.2 (x64)
Build ID: 64390860c6cd0aca4beafafcfd84613dd9dfb63a
CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 10 QA Administrators 2023-04-21 03:27:21 UTC Comment hidden (obsolete)
Comment 11 David F Smith 2023-04-21 13:25:21 UTC
I have retested under 7.4.6.2, and now the results are exactly what I expect.  I have changed the status to RESOLVED-WORKSFORME.

Thank you.

Version: 7.4.6.2 (x64) / LibreOffice Community
Build ID: 5b1f5509c2decdade7fda905e3e1429a67acd63d
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded