Description: Since early 2017, LO supports ligatures and other OpenType features. You can activate and deactive them easily by adding :feature or :-feature to the font name. – activate: font:feature (Calibri:tnum) – deactivate font:-feature (Calibri:-liga) With LO 6.2.0.3, :-feature doesn't work anymore. Since standard ligatures (liga) are already activated as a default setting, it's impossible to deactive them. Steps to Reproduce: 1. Use a font that supports ligatures (like Calibri) and enter fi, ffi, fl or ffl. 2. Mark the text and add :-liga to the font name (Calibri:-liga) Actual Results: The ligatures remain. Expected Results: The ligatures disappear. Reproducible: Always User Profile Reset: Yes Additional Info:
I confirm that with Version: 6.3.0.0.alpha0+ (x64) Build ID: f42554a1886ebe49170c25096dc3281b2c7bb1f4 CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; TinderBox: Win-x86_64@42, Branch:master, Time: 2019-02-08_22:37:30 Locale: en-US (de_DE); UI-Language: en-US Calc: threaded in comparison to Version: 6.1.5.2 (x64) Build-ID: 90f8dcf33c87b3705e78202e3df5142b201bd805 CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; Gebietsschema: de-DE (de_DE); Calc: group threaded
Created attachment 149270 [details] sample file document using Linux Biolinum G:liga Linux Biolinum G:-liga Linux Biolinum G
Created attachment 149271 [details] Comparison master and 6.1
Created attachment 149272 [details] how it should look
Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=dc9ee533dc707cc10b99d537eaccc3ee5aa555fe author Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk> 2018-06-15 19:32:15 +0200 committer Tomaž Vajngerl <quikee@gmail.com> 2018-06-16 18:04:31 +0200 commit dc9ee533dc707cc10b99d537eaccc3ee5aa555fe (patch) tree bbe8c7547aac7b0440f874ed39945faa60a84276 parent 099eef24da24d638fdf2c747d28040c9b3a30780 (diff) vcl: parser of font features included in the font name Bisected with: bibisect-linux64-6.2 Adding Cc: to Tomaž Vajngerl
Also affects calt (Contextual Alternates) which is also on by default. Today using v6.2.0.3 I noticed I could not disable calt (Vollkorn:-calt). Thought it may be the font but I checked documents last edited 2/4/2019 where -calt was working with other fonts, and they also are not working now since updating LO from 6.1.4.2 to 6.2.0.3.
(In reply to Xisco Faulí from comment #5) > Regression introduced by: > > https://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=dc9ee533dc707cc10b99d537eaccc3ee5aa555fe > > author Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk> 2018-06-15 19:32:15 > +0200 > committer Tomaž Vajngerl <quikee@gmail.com> 2018-06-16 18:04:31 +0200 > commit dc9ee533dc707cc10b99d537eaccc3ee5aa555fe (patch) > tree bbe8c7547aac7b0440f874ed39945faa60a84276 > parent 099eef24da24d638fdf2c747d28040c9b3a30780 (diff) > vcl: parser of font features included in the font name > > Bisected with: bibisect-linux64-6.2 > > Adding Cc: to Tomaž Vajngerl This commit replaces the use of hb_feature_from_string() with a much simpler feature syntax parser, which probably breaks more things as HarfBuzz syntax is more elaborate.
https://gerrit.libreoffice.org/#/c/69062/
Khaled Hosny committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/45deb5b714d2d011eb2a5ad91721a9c2c508a426%5E%21 tdf#123304: Allow the full feature syntax as pre 6.2 It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Khaled Hosny committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/3450311c403af714d3fc0ba14b9f7673c717a6a2%5E%21 tdf#123304: Allow the full feature syntax as pre 6.2 It will be available in 6.2.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified in Version: 6.3.0.0.alpha0+ Build ID: 8aa579830b20072af8d6e149d6b279362fe98b91 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); UI-Language: en-US Calc: threaded @Khaled Hosny, thanks for fixing this issue!
Khaled Hosny committed a patch related to this issue. It has been pushed to "libreoffice-6-2-2": https://git.libreoffice.org/core/+/5f3271f75383d4580299f0a38e57353fe161c3a6%5E%21 tdf#123304: Allow the full feature syntax as pre 6.2 It will be available in 6.2.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.