Steps: 1) Open LO 2) Tools > Options or Tools > Customize > Menus > Menu Content 3) See cramped text in the tree view or listbox Version: 5.4.0.0.alpha0+ Build ID: 04edc5c796c1b96e5228d0c1fcf73bcf52465b66 CPU threads: 2; OS: Linux 3.19; UI render: default; VCL: gtk2; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2017-04-15_03:25:45 Locale: en-US (en_US.UTF-8); Calc: group
Could you please attach a screenshot ?
Created attachment 132669 [details] 5.2 vs 5.4
Not a HarfBuzz issue. That is related to the new line spacing strategy which is more faithful to the font and more spec complaint. If the font has narrow line spacing then because it was built that way.
What is your UI font?
(In reply to Khaled Hosny from comment #4) > What is your UI font? Noto Sans on Linux Mint 17.3 Mate. It looks even worse on my Ubuntu Mate 16.04 installation which uses Ubuntu font.
Created attachment 132670 [details] cramped text on ubuntu mate 16.04
Hmm, the fonts look fine (at least the versions of the fonts I have here). Do you get the same tight spacing if you use the fonts in Writer documents?
(In reply to Khaled Hosny from comment #7) > Hmm, the fonts look fine (at least the versions of the fonts I have here). > Do you get the same tight spacing if you use the fonts in Writer documents? The only time i notice this issue is in dialogs.
(In reply to Yousuf Philips (jay) from comment #8) > (In reply to Khaled Hosny from comment #7) > > Hmm, the fonts look fine (at least the versions of the fonts I have here). > > Do you get the same tight spacing if you use the fonts in Writer documents? > > The only time i notice this issue is in dialogs. No idea what is going on then; a line spacing change should show up everywhere.
(In reply to Khaled Hosny from comment #9) > No idea what is going on then; a line spacing change should show up > everywhere. The system font isnt used within my documents, its is in widget controls.
Created attachment 132698 [details] 5.3 vs. 5.4 background: Version: 5.3.2.2 Build ID: 5.3.2-1 CPU Threads: 8; OS Version: Linux 4.10; UI Render: default; VCL: kde4; Layout Engine: new; Locale: en-US (en_US.UTF-8); Calc: group foreground: Version: 5.4.0.0.alpha0+ Build ID: 80be4d22afd99c72ea6887e3f2dac86f5e80f75c CPU threads: 8; OS: Linux 4.10; UI render: default; VCL: kde4; Locale: en-US (en_US.UTF-8); Calc: group LXQt/Kwin/Breeze/Noto Sans
GTK2 only?
Is anyone running Ubuntu or one of its derivatives to test this on?
Created attachment 132931 [details] 5.2 gtk2 vs 5.4 gtk3 (In reply to Buovjaga from comment #12) > GTK2 only? GTK3 as well.
I see the same difference comparing e.g. 4.4.7 and Version: 5.4.0.0.alpha0+ Build ID: 74ccd02eda2d6325a27266fd935aba29b3d75020 CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk2; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2017-04-27_23:51:14 Locale: nl-NL (nl_NL.UTF-8); Calc: group
Created attachment 132932 [details] 5.2.7.2 vs. 5.4 Old version in the background / left, master in front at right
(In reply to Cor Nouws from comment #15) > I see the same difference comparing e.g. 4.4.7 and Version: 5.4.0.0.alpha0+ > Build ID: 74ccd02eda2d6325a27266fd935aba29b3d75020 > CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk2; > TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: > 2017-04-27_23:51:14 > Locale: nl-NL (nl_NL.UTF-8); Calc: group Using Ubuntu 17.04
Created attachment 132936 [details] Heiko's screenshot aligned properly (In reply to Heiko Tietze from comment #16) > Created attachment 132932 [details] > 5.2.7.2 vs. 5.4 So i lined things up better in your screenshot and the issue isnt showing up in your system. The first 6 child entries only need to be compared as 'Colors' and 'Online Update' arent in the list in 5.4.
bisected: author Khaled Hosny <khaledhosny@eglug.org> 2016-11-09 13:22:43 (GMT) committer Khaled Hosny <khaledhosny@eglug.org> 2016-11-22 15:32:11 (GMT) commit 34d7602954d4483b3bc9db700e7df2c15348947a (patch) tree 8dcfb93fc29815fd89481a7840d64d6c187534db parent c855aec445628f96d3d32cfde6efd4e51e4489c9 (diff) tdf#55469 Consistent line spacing across platforms
Created attachment 133161 [details] cropped labels So the issue also affects dialog labels
@Alex, @Steve, @Telesto: Can either of you guys confirm this on Mac?
I don't see any difference between 5.4 and older versions (on Mac & Windows). It always looked cramped.
(In reply to Telesto from comment #22) > I don't see any difference between 5.4 and older versions (on Mac & > Windows). It always looked cramped. Can you give a screenshot of 5.2 vs 5.4 for the options dialog on Mac.
Created attachment 133869 [details] 5.2 vs 5.4 mac I was wrong; there is a difference between 5.2 and 5.4. Sorry for the inconvenience
Created attachment 133870 [details] 5.2 vs 5.4 mac I was wrong; there is a difference between 5.2 and 5.4. Sorry for the inconvenience
This bug would also making conveniences for Windows touch screen devices, especially Surface.
See my Bug 108710 for Writer - which I suspect is a directly related problem. In Writer I observed a significant line spacing reduction from version 5.3 BUT ONLY when in Web View. Also the line spacing there changes significantly as the zoom is changed. 100% seems to have the smallest line spacing.
Created attachment 135709 [details] comparison Libreoffice 4.4 and LibreOffice 6.0 (Linux/gen)
Created attachment 135710 [details] comparison Libreoffice 4.4 and LibreOffice 6.0 (win)
https://gerrit.libreoffice.org/#/c/41933/ makes this problem better as far as I can see
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e2159061db8e266a3fe9f31773c676887168b254 Resolves: tdf#107249 round ascent/descent/extleading on conversion to int It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Caolán McNamara from comment #30) > https://gerrit.libreoffice.org/#/c/41933/ makes this problem better as far > as I can see Cool now protecting ascent/descent from truncation of the "external leading" by taking it explicitly through round(). But does the mnHeight need to be similar? Is the mnHeight at line 448 for calculating the "internal leading" (mnIntLeading) unrounded and also unscaled? And down the road, does all this integer font sizing get dropped when bug 103322 gets some attention?
(In reply to V Stuart Foote from comment #32) > Cool now protecting ascent/descent from truncation of the "external leading" > by taking it explicitly through round(). > through round() after scaling as float
Stephan Bergmann committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=93786f7c79b3ae61feed42d397cbbdbd8107d152 Revert "Resolves: tdf#107249 round ascent/descent/extleading on conversion to int" It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0c8b749e602b6743857a9bc4efb24b6183690311 Resolves: tdf#107249 round ascent/descent/extleading on conversion to int It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Thanks, Caolán!
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-5-4": http://cgit.freedesktop.org/libreoffice/core/commit/?id=60eed46d4b24b9b9eaa1ebd0a8f185900176aed5&h=libreoffice-5-4 Resolves: tdf#107249 round ascent/descent/extleading on conversion to int It will be available in 5.4.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-5-3": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e0ea7df25faeaae9f98ebde32f49eec92603d629&h=libreoffice-5-3 Resolves: tdf#107249 round ascent/descent/extleading on conversion to int It will be available in 5.3.7. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Created attachment 136061 [details] tools -> options dialog better line spacing master > 20170906